Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

Add unit tests for spectrum attributes, including empty #274

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Add unit tests for spectrum attributes, including empty #274

merged 2 commits into from
Apr 11, 2019

Conversation

ajoubertza
Copy link
Member

The idea of this PR is to see that the tests fail before merging PR #273, and that they pass afterwards (I'll merge develop into this branch).

Tests added that:

  • Verify basic reading and writing of spectrum attributes.
  • Verify that clients reading empty spectrum attributes get a None value. The string spectrum attribute is a special case as it doesn't reduce its length when written to.

Relates to issue #271, and PR #273.

@ajoubertza
Add unit tests for spectrum attributes, including empty
3a25677 
- Verify basic reading and writing of spectrum attributes.
- Verify that clients reading empty spectrum attributes get a
  `None` value.  The string spectrum attriubte is a special case as
  it doesn't reduce its length when written to.

Relates to issue #271, and PR #273
@jairomoldes
Copy link
Contributor

jairomoldes commented Apr 11, 2019 •
edited
Loading

Seems OK. I checked that tests pass if #273 is applied.

@jairomoldes jairomoldes merged commit 9cf78c5 into develop Apr 11, 2019
@ajoubertza ajoubertza deleted the test-issue-271 branch April 11, 2019 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajoubertza @jairomoldes