This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
push_data_ready_event() deadlock (issue-22) #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
although we store device names in lower case; the same code might be necessary in other places? needs review
seems it is a dictionary and '.iteritems()' was missing in for loop
| long ctr) | ||
| { | ||
| SAFE_PUSH(self, attr, name) | ||
| self.push_data_ready_event(__att_name, ctr); //__att_name from SAFE_PUSH |
There was a problem hiding this comment.
I noticed that push_archive_event calls attr.fire_archive_event(). Is there any reason why you're not using something similar, e.g. attr.fire_data_ready_event()?
There was a problem hiding this comment.
It looks like Attribute cpp class only provides these methods:
- Attribute::fire_archive_event
- Attribute::fire_change_event
- Attribute::fire_event
- Attribute::fire_error_periodic_event
I can't see any "fire_data_ready_event" nor anything similar that could be used. Any suggestion?
There was a problem hiding this comment.
OK, I was just curious about it.
|
Has it been tested against the example scenario in issue #22? |
|
Yes, I tested the solution using the sample code in #22 |
|
Great! Then it should be safe to merge. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this fixes issue-22