This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
DevEncoded attribute should produce a bytes object in python 3 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajoubertza
reviewed
Sep 6, 2018
ext/device_attribute.cpp
Outdated
| py_value.attr(value_attr_name) = | ||
| bopy::make_tuple(r_encoded_format, r_encoded_data); | ||
|
|
||
| boost::python::object r_encoded_data( |
There was a problem hiding this comment.
Minor, but this line's indentation looks different to the others in the github view. Maybe hard tab vs soft tab issue?
ext/device_attribute.cpp
Outdated
| bopy::make_tuple(r_encoded_format, r_encoded_data); | ||
|
|
||
| boost::python::object r_encoded_data( | ||
| boost::python::handle<>(PyBytes_FromStringAndSize( |
There was a problem hiding this comment.
In other parts of this file with similar code uses bopy::handle<>, rather than boost::python::handle<>. E.g.
pytango/ext/device_attribute.cpp
Line 186 in 5945e17
I don't know what either do, so just checking if it makes a difference?
ext/device_attribute.cpp
Outdated
| bopy::str w_encoded_data(w_ch_ptr, w_encoded_data_array.length()); | ||
| py_value.attr(w_value_attr_name) = | ||
|
|
||
| boost::python::object w_encoded_data( |
There was a problem hiding this comment.
Indentation differs here too.
tests/test_server.py
Outdated
|
|
||
| @attr.write | ||
| def attr(self, value): | ||
| print(value) |
There was a problem hiding this comment.
Is this print still useful, or was it just to aid debugging?
|
@ajoubertza Thanks for the review, it's all fixed. |
|
@ajoubertza Feel free to merge it then :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #213.