This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Issue 13 Pipe Events #104
Merged
Issue 13 Pipe Events #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.gitignore
Outdated
| # Eclipse users | ||
| .project | ||
| .pydevproject | ||
| .settings/ |
There was a problem hiding this comment.
editor related filters should be in your private .git/info/exclude
tango/base_types.py
Outdated
|
|
||
| *DATA_READY_EVENT - New in PyTango 7.0.0* | ||
| *INTERFACE_CHANGE_EVENT - New in PyTango 9.2.2* |
There was a problem hiding this comment.
This pull request should not concern INTERFACE_CHANGE_EVENT
tango/device_proxy.py
Outdated
| @@ -1183,6 +1185,10 @@ def __DeviceProxy__get_events(self, event_id, callback=None, extract_as=ExtractA | |||
| return self.__get_attr_conf_events(event_id, extract_as) | |||
| elif event_type in (EventType.DATA_READY_EVENT,): | |||
| return self.__get_data_ready_events(event_id, extract_as) | |||
| elif event_type in (EventType.INTERFACE_CHANGE_EVENT,): | |||
| raise NotImplementedError("event_type not implemented event_type: " + str(event_type)) | |||
There was a problem hiding this comment.
This pull request should not concern INTERFACE_CHANGE_EVENT
tango/utils.py
Outdated
| @@ -1415,6 +1415,9 @@ def _get_value(self, evt): | |||
| return "label='%s'; unit='%s'" % (cfg.label, cfg.unit) | |||
| elif isinstance(evt, DataReadyEventData): | |||
| return "" | |||
| elif isinstance(evt, PipeEventData): | |||
| print ("utils::_get_value()") | |||
There was a problem hiding this comment.
I suspect this is a debug print that should be removed
tango/utils.py
Outdated
| @@ -1415,6 +1415,9 @@ def _get_value(self, evt): | |||
| return "label='%s'; unit='%s'" % (cfg.label, cfg.unit) | |||
| elif isinstance(evt, DataReadyEventData): | |||
| return "" | |||
| elif isinstance(evt, PipeEventData): | |||
| print ("utils::_get_value()") | |||
| return | |||
There was a problem hiding this comment.
Shouldn´t it return the pipe value?
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.