This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
Fix API_EventTimeOut #817
Merged
Fix API_EventTimeOut #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ango-controls#686) Subscribing or unsubscribing events in an event callback when this callback was called during a subscribe_event() phase was leading to events and heartbeat events no longer received by the event client. A bug was fixed when several ZMQ_DELAY_EVENT commands were received consecutively by the ZMQ control socket.
mliszcz
reviewed
Nov 26, 2020
…Consumer class member variable
Convert nb_current_delay_event_requests static variable to a ZmqEvent…
mliszcz
approved these changes
Dec 1, 2020
|
@bourtemb Are we good to go? Although you did the code, as I've opened the PR, it is you who has to review. |
bourtemb
approved these changes
Dec 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port #699.
Close #686.