This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
9.3 backport to fix #330 #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add macros to support logging from outside of device code, but where a pointer to device implementation is available.
If attribute was in ALARM state (e.g. due to max_value being exceeded) and reading started to fail, the attribute should not impact Device state any more (Device stays ON). If later reading starts to work again, the Device shall also switch to ALARM state.
If no value was provided for an attribute during read (e.g. exception was thrown), set attribute's quality to invalid to ensure that alarm condition is not evaluated (it is not possible as the value is missing).
mliszcz
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
@bourtemb I'm not sure if I'm the right person to review this PR as I authored the original one. Anyway, from my POV the is nothing that could prevent this correction from being backported to 9.3 branch, as there is just one new, non-virtual, private method.
Still, thanks for taking care of the backport!
t-b
approved these changes
Mar 18, 2020
bourtemb
added a commit
to bourtemb/cppTango
that referenced
this pull request
Mar 31, 2020
- Add logs for tango-controls#681 and tango-controls#690 - Fix some broken links
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.