This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
PR to fix #359 #503
Merged
PR to fix #359 #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this fix (if it really fixes the pb) is quite simple so we should keep it simple. This change introduces a change in the behaviour of the events (an additional event is sent the first time the polling is executed), so this has an impact on the tests as we can see (it was expected). |
|
@bourtemb , ok! |
bourtemb
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can take a chance to refactor event supplier a little bit here as well...