Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Add SonarCloud.io #478

Merged
merged 7 commits into from
Aug 28, 2018
Merged

Add SonarCloud.io #478

merged 7 commits into from
Aug 28, 2018

Conversation

Ingvord
Copy link
Member

@Ingvord Ingvord commented Aug 21, 2018

SonarCube hosted on sonarcloud.io seems to be much better alternative(addition) to codacy.

Result of the analysis of this branch can be found here

@Ingvord Ingvord requested a review from bourtemb August 22, 2018 19:10
Copy link
Member

@bourtemb bourtemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When looking quickly through sonarcloud documentation (https://docs.sonarqube.org/display/PLUG/Building+on+Linux), it seems we must to run build-wrapper-linux-x86-64 before sonar-scanner for C++ projects.
I saw somewhere this could avoid some false positives.

There is a project referenced by https://github.com/SonarSource/sonarcloud_examples with a C++ example where they run build-wrapper-linux-x86-64 before executing sonar-scanner: https://github.com/SonarSource/sq-com_example_c-sqscanner-travis/blob/master/.travis.yml

@Ingvord
Copy link
Member Author

Ingvord commented Aug 23, 2018

@bourtemb , yes, you are absolutely right! That would be further improvement. We just need to figure out how to integrate build-wrapper into our dockers (which BTW would be nice to replace with native Travis images if possible). Anyway at this point it is already a good result, and I like the result of the analysis.

@bourtemb
Copy link
Member

I understand...
Can we add a sonarcloud badge to the README too?

@Ingvord
Copy link
Member Author

Ingvord commented Aug 23, 2018

@bourtemb , sure! Once we merge it and run analysis on the tango-9-lts branch we can add sonar metrics to readme, like in JTango's readme

@Ingvord Ingvord merged commit 0023afc into tango-9-lts Aug 28, 2018
@Ingvord
Copy link
Member Author

Ingvord commented Aug 31, 2018

@bourtemb , build-wrapper is added in fbc9707

Interesting that with build-wrapper sonar found 158 new bugs and 30 vulnerabilities and coverage has dropped from 49 to 33%. Anyway I feel we have now much better picture

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants