Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Tango 9 lts remove zmq hpp #412

Closed

Conversation

bourtemb
Copy link
Member

@bourtemb bourtemb commented Nov 6, 2017

Remove zmq.hpp from tango-9-lts (#266)
Add CPPZMQ_BASE CMake optional variable

@t-b
Copy link
Collaborator

t-b commented Nov 6, 2017

@bourtemb Is cppzmq now a required dependecy? If yes cmake should also complain if it could not be found or?

@bourtemb
Copy link
Member Author

bourtemb commented Nov 6, 2017

Well, zmq.hpp file is required.
On Debian it is distributed with zmq Debian packages.
On some other platforms, it might be independent.
Maybe we should add a CHECK_INCLUDE_FILE line to ensure it is available on the system and give a nice message explaining this requirement if the file is not found....

@t-b
Copy link
Collaborator

t-b commented Nov 6, 2017

Maybe we should add a CHECK_INCLUDE_FILE line to ensure it is available on the system and give a
nice message explaining this requirement if the file is not found....

yes that sounds good!

message(FATAL ...) replaced with message(FATAL_ERROR ...)
@t-b
Copy link
Collaborator

t-b commented Nov 8, 2017

@bourtemb THanks, I've just tested it here locally and it works.

@bourtemb
Copy link
Member Author

bourtemb commented Nov 8, 2017

@t-b Thank you very much for your feedback and for having taken the time to test it.

@bourtemb
Copy link
Member Author

bourtemb commented Dec 8, 2017

Closing this PR since it is now handled by PR #421

@bourtemb bourtemb closed this Dec 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants