fix item wrapper when using item slot API #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimalghartimagar
pushed a commit
to bimalghartimagar/vue-virtual-scroll-list
that referenced
this pull request
Jan 21, 2024
* fix item slot * fix item slot * fix item slot * fix item slot * fix item slot
|
how to use this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of this PR? (check at least one)
Other information:
With the addition of this PR. which allows to use a
<template #item="{ item }">, it added a newdivwrapper every time, which will be around the element we pass in:item-tagprop. This essentially breaks the usage of this package for tables, since it will do this:So when you chose the
:item-tagto betrtogether with theitemslot API, it will never work, since it will break your table.This PR removes that
divwrapper when theitemslot API is used. Basically we don't need to callh(createElement) again when the item-slot API is being used.