Controller: preloading ctrl & data #77
Closed
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tancheng
reviewed
Feb 4, 2025
controller/ControllerRTL.py
Outdated
| @@ -249,6 +302,42 @@ def update_received_msg(): | |||
| # # TODO: Handle other cmd types. | |||
| # assert(False) | |||
|
|
|||
| if controller_id == 0: | |||
There was a problem hiding this comment.
Why do we still have such check, this is not aligned with our discussion
There was a problem hiding this comment.
Do you mean the input of recv_ctrl_pkt_queue is only recv_from_cpu_pkt,
and the decoded ctrl signals from recv_from_noc are directly sent to send_to_ctrl_ring_ctrl_pkt?
There was a problem hiding this comment.
Right, just isolate CMD_CONFIG from elif (s.recv_from_noc.msg.cmd == CMD_STORE_REQUEST) | (s.recv_from_noc.msg.cmd == CMD_CONFIG), send the ctrl signals to the ctrl_ring here. How does it sound?
controller/ControllerRTL.py
Outdated
|
|
||
| s.recv_ctrl_pkt_queue = NormalQueueRTL(CtrlPktType) | ||
| s.recv_ctrl_pkt_queue = ChannelRTL(FromCpuPktType, latency = 1) |
There was a problem hiding this comment.
The recv_ctrl_pkt_queue should be renamed to recv_from_cpu_pkt_queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.