[Podspec] Remove circular dependency #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You do not need to explicitly depend on a subspace since by default it will be included. The subspec will contain the dependency from it's parent spec and therefore lead to a circular dependency. As noted in CocoaPods/Molinillo#6, the coming version of CocoaPods will now allow this.
|
Note, this has also been fixed by CocoaPods/Specs@5324427 in the PR over at the master specs repository: CocoaPods/Specs#12783. |
taka0125
added a commit
that referenced
this pull request
Nov 8, 2014
[Podspec] Remove circular dependency
|
@kylef thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You do not need to explicitly depend on a subspace since by default it will be included. The subspec will contain the dependency from it's parent spec and therefore lead to a circular dependency.
As noted in CocoaPods/Molinillo#6, the coming version of CocoaPods will now allow this.