Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow returning custom position from shouldUpdateScroll #53

Merged
merged 1 commit into from
Apr 13, 2016
Merged

Allow returning custom position from shouldUpdateScroll #53

merged 1 commit into from
Apr 13, 2016

Conversation

jondkoon
Copy link
Contributor

Per conversation in #52

@jondkoon jondkoon mentioned this pull request Apr 13, 2016
Closed
@jondkoon jondkoon closed this Apr 13, 2016
@jondkoon jondkoon reopened this Apr 13, 2016
@jondkoon
Copy link
Contributor Author

Tests are pretty flaky

@taion
Copy link
Owner

taion commented Apr 13, 2016

Yeah, that's my bad. I'll take care of it.

@taion
Copy link
Owner

taion commented Apr 13, 2016

Thanks!

@taion taion merged commit 797a86f into taion:master Apr 13, 2016
@jondkoon
Copy link
Contributor Author

Thanks!

@taion
Copy link
Owner

taion commented Apr 13, 2016

I'm going to try to sort out the scroll update thing. Will cut a release later today.

@jondkoon jondkoon deleted the should_update_scroll_uses_position branch April 13, 2016 21:02
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jondkoon @taion