Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding touch-action utility #4727

Closed

Conversation

MatteoGauthier
Copy link
Contributor

Hey guys, i added the touch-action css property to tailwind :D

Copy link
Member

@adamwathan adamwathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for this one, had this on my list to add soon so cool to have it come in as a PR! Left a few bits of feedback for things that need to change but generally looks good, thanks again.

tests/jit/basic-usage.test.html Show resolved Hide resolved
stubs/defaultConfig.stub.js Outdated Show resolved Hide resolved
src/plugins/index.js Outdated Show resolved Hide resolved
@MatteoGauthier
Copy link
Contributor Author

MatteoGauthier commented Jun 21, 2021

Thanks @adamwathan for your review, I tried to correct issues you noticed 📍

@MatteoGauthier
Copy link
Contributor Author

I don't know why the test fail..

@sachinraja
Copy link
Contributor

I think the problem is that you didn't regenerate the fixtures after moving the import position. Looks like you'll also have to change the class's position in tests/jit/basic-usage.test.css. Tests pass for me after addressing both of these issues.

So you need to:

  1. npm run rebuild-fixtures
  2. move the touch-manipulation class to right after cursor-pointer in tests/jit/basic-usage.test.css.

@reinink reinink self-assigned this Sep 23, 2021
@adamwathan
Copy link
Member

Hey! We refactored the living hell out of the codebase since the time you opened this, so I just opened a new PR and included you as a co-author just to get this merged in quickly 👍🏻

#5603

Thanks a ton man!

@adamwathan adamwathan closed this Sep 26, 2021
@MatteoGauthier MatteoGauthier deleted the touch-action branch September 26, 2021 13:48
@MatteoGauthier
Copy link
Contributor Author

Hey! We refactored the living hell out of the codebase since the time you opened this, so I just opened a new PR and included you as a co-author just to get this merged in quickly 👍🏻

#5603

Thanks a ton man!

Thanks Adam ! Have a good day :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants