-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Oxide scanner bugs #15974
Fix Oxide scanner bugs #15974
Conversation
545a30b
to
491fe9b
Compare
in version 4.0.1 the bug is still present (almost for angular shorthand syntax) |
@paolominel What's the exact file you've used that doesn't work? |
I use tailwind classes in angular host component.
active variable was a signal inside the relative angular component. this class was not fired and not compiled during tailwind class scanning. |
still present in version 4.0.3. tried this morning after library upgrade |
Fixes #15632
Fixes #15740
This PR fixes a number of Oxide scanner bugs reported over various channels, specifically:
When using the Svelte class shorthand split over various lines, we weren't extracting class names properly:
We now extract classes when using the class shortcut in Angular:
We now validate parentheses within arbitrary candidates so that we don't consume invalid arbitrary candidates anymore which allows us to parse the following case properly:
Test plan
Added unit tests