Add musl binaries to the Standalone CLI #15567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d64ba4 to
c6cb9a9
Compare
We have separate MUSL binaries so there’s no longer a reason for us to bundle GLIBC and MUSL node addons
It fixes building Musl standalone binaries
b4f4e38 to
4b03b20
Compare
philipp-spiess
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Actually need to add this here as well: https://github.com/tailwindlabs/tailwindcss/blob/next/.github/workflows/release.yml#L265-L271. If you comment out the npm release part it should be fine to run the release pipeline in this PR too and we can test the artifacts that are uploaded to the run.
|
Are we sure that it's fine? I've had the release workflow overwrite / replace an existing release before unintentionally. edit: I made a copy of the release notes / binaries in case something goes awry. |
|
verified all is good: 
|
e162c51 to
4e19bbe
Compare
philipp-spiess
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15031
This adds musl binaries for the Standalone CLI on Linux aarch64 (ARM 64-bit) and x86_64 (Intel/AMD 64-bit).
I tested this by temporarily running the release workflow (without publishing) to build the Standalone CLI, downloading the artifacts, and running the musl binaries in two docker containers.
(sorry for the potato screenshot — tested x64 through my AMD Windows machine over parsec)