Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure font-stretch utilities only accepts positive integer bare values #14670

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

RobinMalfait
Copy link
Member

This PR fixes an issue where bare values in the font-stretch utility such as font-stretch-50.5% compiled. But for bare values, we want these values to be positive integers only so that we don't have too many special characters.

If you want to use 50.5%, you can still use font-stretch-[50.5%] as a utility.

Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@RobinMalfait RobinMalfait changed the title Validate bare value for font-stretch utilities Ensure font-stretch utilities only accepts positive integer bare values Oct 15, 2024
@RobinMalfait RobinMalfait enabled auto-merge (squash) October 15, 2024 09:35
@RobinMalfait RobinMalfait merged commit 36acad0 into next Oct 15, 2024
1 check passed
@RobinMalfait RobinMalfait deleted the fix/font-stretch-bare-value branch October 15, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants