Automate checksum generation for standalone CLI #14081
Conversation
There was a problem hiding this comment.
@RobinMalfait do you know of a good way to test this w/o creating a tag? Should I add a workflow_dispatch trigger to the prepare release workflow?
Maybe it's fine to run npm run build locally to validate this. Otherwise the workflow_dispatch trigger makes sense IMO but if we want to run a full release we might need to make it a --dry-run somewhere.
The changes look good to me, though :)
| './tailwindcss-windows-x64.exe', | ||
| ] | ||
|
|
||
| const __dirname = path.dirname(new URL(import.meta.url).pathname) |
There was a problem hiding this comment.
Learned today that this will fail on Windows and you're supposed to use the fileURLToPath helper 🙈 https://github.com/tailwindlabs/tailwindcss/pull/14065/files#diff-8cdc2dcef376d2bbc6b8c9029a227c928f2aaa0f460776ba24d9d3eba110aab1
There was a problem hiding this comment.
Luckily, we don't have to worry about this for this particular case since it will be executed on a linux machine
There was a problem hiding this comment.
yeah but we should use to fileURLToPath anyway just for consistency and what not
There was a problem hiding this comment.
@RobinMalfait haha yep you are right. My intention of sharing this was more to share what I have just learned anyways.
But I think I agree with @thecrypticace that we should probably keep this consistent so that the next time someone copies from this script, they start with a better default and it won't bring surprises on Windows.
|
Yeah I would go for a manual It looks good to me, but my only fear is that the Another alternative is to try and setup act (https://github.com/nektos/act) but that might not be as straightforward because of the generated executables. |
Seems like we use Node 20 for the releases as we also do for the CI: https://github.com/tailwindlabs/tailwindcss/blob/next/.github/workflows/release.yml#L17 |
|
Wrong branch: https://github.com/tailwindlabs/tailwindcss/blob/master/.github/workflows/prepare-release.yml#L25 We're using node 16 so… we need to update that if we can. 😱 |
|
Gonna merge this and give it a test. I think I need to create a dummy tag first though b/c if I don't it'll overwrite the existing release (which would be bad) |
We've done this manually until now which is fine but not ideal so this PR automates it so it cannot be forgotten.
@RobinMalfait do you know of a good way to test this w/o creating a tag? Should I add a
workflow_dispatchtrigger to the prepare release workflow?