Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pnpm #1029

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Migrate to pnpm #1029

merged 6 commits into from
Aug 6, 2024

Conversation

philipp-spiess
Copy link
Member

To be consistent with the defaults of the Tailwind V4 repo, I figured it might make sense to also migrate the intellisense extension to use pnpm as the default version manager.

This was mostly motivated by me doing a clean npm install in the workspace root but that causes a lot of packages to be missing within packages/vscode-tailwindcss (e.g. the concurrently module) so builds wouldn't just work. 😬

@philipp-spiess philipp-spiess marked this pull request as draft August 6, 2024 12:50
@philipp-spiess philipp-spiess force-pushed the chore/migrate-to-pnpm branch 2 times, most recently from 9f57f6b to 3e841d9 Compare August 6, 2024 12:54
@philipp-spiess philipp-spiess force-pushed the chore/migrate-to-pnpm branch from 3e841d9 to 3fcec52 Compare August 6, 2024 13:09
@philipp-spiess philipp-spiess force-pushed the chore/migrate-to-pnpm branch from 3fcec52 to 4df1b05 Compare August 6, 2024 13:34
@philipp-spiess philipp-spiess marked this pull request as ready for review August 6, 2024 15:07
@thecrypticace
Copy link
Contributor

I've fixed all the TypeScript issues, test issues, etc…

So only thing now is figuring out how to replace the workspace:* bit from the package.json of the packaged extension. It's only dev deps so won't ever actually be installed. And maybe it's not an issue at all but I'm not sure I'd count on that being future proof.

@thecrypticace
Copy link
Contributor

From what I can tell in my testing the workspace:* deps in dev dependencies don't break the built VSIX file. So I think the best option here is to merge and see if the marketplace extension validation complains for insiders builds.

"@types/culori": "^2.1.0",
"culori": "^4.0.1",
"esbuild": "^0.20.2",
"minimist": "^1.2.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like that these deps have to be at the root package level but it's happening because the shared esbuild.mjs file is at the root level rather than having an exact copy inside each package.

@thecrypticace thecrypticace merged commit 82f152d into master Aug 6, 2024
@thecrypticace thecrypticace deleted the chore/migrate-to-pnpm branch August 6, 2024 18:29
@philipp-spiess
Copy link
Member Author

@thecrypticace thanks for fixing this up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants