Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #44 remove unnecessary spaces #94

Closed
wants to merge 1 commit into from
Closed

fix: #44 remove unnecessary spaces #94

wants to merge 1 commit into from

Conversation

neotan
Copy link

@neotan neotan commented Aug 31, 2022

Fix:

#7560
#7559
#44

Notes:

Executed the npm run format script, so there are some code format changes.

@adamwathan
Copy link
Member

adamwathan commented Aug 31, 2022

Hey! We are going to hold off on this feature for now because of complications mentioned here:

#71

We shipped it once but it’s a lot more complicated than it looks.

If you want to take a stab at something that also handles those situations properly and includes tests for them definitely open to it, but please don’t include formatting changes in the PR to unrelated code as it makes it difficult to review, I’ll have to look into why that’s happening with the format script 🤔 Thanks regardless!

@adamwathan adamwathan closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants