Introduce tailwindStylesheet option to replace tailwindEntryPoint
#330
+69
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old option will still work but the new one is much better named
This is a compatability feature. People previously used the `tailwindConfig` option to specify the location of their config and naturally expect it to work with a CSS file in v4. The preferred option is `tailwindStylesheet` but making this work is rather simple so it should “just work” for improved DX
c46a51c to
8ea654c
Compare
reinink
reviewed
Nov 18, 2024
reinink
reviewed
Nov 18, 2024
reinink
reviewed
Nov 18, 2024
Co-authored-by: Jonathan Reinink <jonathan@reinink.ca>
Co-authored-by: Jonathan Reinink <jonathan@reinink.ca>
Co-authored-by: Jonathan Reinink <jonathan@reinink.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're replacing the existing
tailwindEntryPointoption with atailwindStylesheetoption. The existing option is just not well named and the new one feels more correct.Some notes:
tailwindEntryPointand instruct them to usetailwindStylesheetinsteadtailwindConfigand it'll just work in a v4 project. Note: This will also warn users to usetailwindStylesheetbut it seems like the principle of least surprise to make it work and instruct users on how to upgrade.Fixes #318