Add automated release workflows #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/32EAqT8Ei6YNZ9eRrBMRDBmnqHvb headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/4XREMo3wayQWD4S1i2WwmNCFHFKZ |
RobinMalfait
added a commit
that referenced
this pull request
Oct 8, 2021
RobinMalfait
added a commit
that referenced
this pull request
Oct 8, 2021
This commit also contains new code introduced after the PR in #853 was merged. I just squashed it all together to prevent noisy commits to try and fix CI. The funny thing is that now the final commit looks fairly stupid/simple but it wasn't that easy as I would have liked. 1. Couldn't find a proper way to execute `npm version` using yarn workspaces. `yarn workspaces foreach npm version` would have worked if we were using Yarn 2 instead of Yarn 1. 2. Introducing `version` and `publish` scripts in both packages worked, but then the default `version` and `publish` were also executed. 3. Once I made the scripts unique (`npm-version`, `npm-publish`) it worked~ish. The registry was always set to a yarnpkg registry, even if we set the registry in CI and in a local .npmrc file. My guess is that we are executing in a nested directory and therefore it didn't work. 4. Next, I found the `npm workspaces` option so that we can use that in addition to `yarn workspaces` 🙃 5. In CI of course this didn't work, because I was not using the same node version... 6. After everything worked, I did cleanup of the new scripts, and removed the introduced .npmrc files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we push a commit to the develop branch, a new version should be released to npm using the
devtag.Whenever we push a commit to the main branch, a new version should be released to npm using the
nexttag.This allows me to post the following message on every PR/issue that has been merged/fixed.
I used this message before, but then I manually published those version to npm.
This might take multiple tries...