cmd/systray: handle reconnects to IPN bus #13386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d17796e to
2690e33
Compare
willnorris
approved these changes
Sep 5, 2024
cmd/systray/systray.go
Outdated
| } | ||
| } | ||
|
|
||
| func watchIPNBusOnce(ctx context.Context) error { |
There was a problem hiding this comment.
nit: I'm not sure of a better name, but this makes it sounds like a sync.Once that is really only ever executed once. It's unexported, so not really THAT big of a deal, but just a tad confusing.
There was a problem hiding this comment.
that's fair, renamed to watchIPNBusInner 🤷
When tailscaled restarts and our watch connection goes down, we get stuck in an infinite loop printing `ipnbus error: EOF` (which ended up consuming all the disk space on my laptop via the log file). Instead, handle errors in `watchIPNBus` and reconnect after a short delay. Updates #1708 Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
2690e33 to
ab0973b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tailscaled restarts and our watch connection goes down, we get stuck in an infinite loop printing
ipnbus error: EOF(which ended up consuming all the disk space on my laptop via the log file). Instead, handle errors inwatchIPNBusand reconnect after a short delay.Updates #1708