android: bump OSS #612
Merged
android: bump OSS #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSS and Version updated to 1.81.24-te19c01f5b-gfee71b410 Signed-off-by: Nick Khyl <nickk@tailscale.com>
nickkhyl
commented
Feb 5, 2025
| @@ -134,7 +135,7 @@ func (a *App) runBackend(ctx context.Context) error { | |||
| a.backend = b.backend | |||
| defer b.CloseTUNs() | |||
|
|
|||
| h := localapi.NewHandler(b.backend, log.Printf, *a.logIDPublicAtomic.Load()) | |||
| h := localapi.NewHandler(ipnauth.Self, b.backend, log.Printf, *a.logIDPublicAtomic.Load()) | |||
There was a problem hiding this comment.
In tailscale/tailscale#14910, we updated localapi.NewHandler to include a new ipnauth.Actor parameter.
Currently, it is only used for the new backend-enforced AlwaysOn.Enabled / AlwaysOn.OverrideWithReason policy settings, which are not yet fully supported on Android, so we can use ipnauth.Self here.
We'll need to do something similar to tailscale/corp#26360 -- or better yet, have a unified oss implementation in tailscale.com/ipn/ipnauth -- when we need a proper ipnauth.Actor for Android.
kari-ts
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS and Version updated to 1.81.24-te19c01f5b-gfee71b410