Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bradfitz/custom server #55

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Bradfitz/custom server #55

merged 2 commits into from
Aug 1, 2022

Conversation

bradfitz
Copy link
Member

@bradfitz bradfitz commented Aug 1, 2022

Two commits. First is from @half-duplex that was sent in #45; the second hides it a bit behind a few taps.

Screen.Recording.2022-08-01.at.9.50.57.AM.mov

Signed-off-by: Trevor Bergeron <mal@sec.gd>
@half-duplex
Copy link
Contributor

half-duplex commented Aug 1, 2022

Thanks!
The pitfalls from my attempt in #45 still apply though, if you want a UX better than my debugging hack level thing:

  • The app restart is gross and shouldn't be necessary, but ipnlocal can't update ControlURL after Start() and I couldn't find another clean way to trigger ipnlocal.Start() again. I don't know golang, so don't dare go deeper.
  • It should be clear on the login view (and maybe logged-in view) that a custom server is configured, maybe with an x to remove
  • It should be more obvious in the "custom server" view how to reset to default (erase the contents of the field and save)

@fernandoenzo
Copy link

This looks really good! Hope to see it soon in F-Droid!

at: now,
shown: v,
})
if len(ui.menu.showHistory) >= 6 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd clear showHistory somewhere, so it doesn't accumulate forever.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's cleaned up on line 310 above. We only ever even allocate a slice backing array large enough to store how many times you can click in 5 seconds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified this a bit and removed the debug print on line 318

By default, only show the version number in the login screen's menu.
But if you open and close it a few times, then show the alternate
control plane server option. It's always shown if you've ever edited
the value.

And rename it to just "Change server" and remove "Advanced".

Updates #45
@bradfitz bradfitz force-pushed the bradfitz/custom-server branch from 39da32f to 64c591d Compare August 1, 2022 19:34
@bradfitz bradfitz merged commit b1501eb into main Aug 1, 2022
@DentonGentry
Copy link
Contributor

This functionality is available in the 1.29.72 in the Open Testing track in the Play Store.

It will be present in the next major release 1.30.0.

@DentonGentry DentonGentry deleted the bradfitz/custom-server branch August 2, 2022 00:28
@nnsee
Copy link

nnsee commented Aug 2, 2022

Kudos! Thank you for listening to user feedback and reconsidering your stance, and settling on a very reasonable compromise.

@madjam002
Copy link

It would be amazing if we could see something like this dev menu to set the login server on iOS too!

bugs181 added a commit to bugs181/WireGuardMeshes that referenced this pull request Sep 10, 2022
Headscale now supports Android via official Tailscale app

As of August 1, 2022 @DentonGentry (a contributor of tailscale-android project) said that this feature was rolled out in the Official Android app (major release of 1.30.0).
Source: tailscale/tailscale-android#55 (comment)
@Modificator
Copy link

On version 1.35.0, UI working well, but can not apply custom server url 😅

@megamorf
Copy link

Just fyi, the headscale support has been broken since 1.34.0 - see tailscale/tailscale#6671

@tonygauderman
Copy link

I don't see a method to make this work from the Android TV platform. Once you select the 3 ellipses, I do not see a way to deselect them. The back arrow, which works in other apps to do the same thing, returns you to the Android TV home screen.

@frustrate3200
Copy link

@tonygauderman Hi, Have you found a solution for android tv yet? Thank you!

@basnappl
Copy link

@tonygauderman & @frustrate3200, I suggest trying to use this tool with your Android TV: https://github.com/Genymobile/scrcpy

This might allow you to tap the ellipsis as on a touch-enable android device.

@godsgood33
Copy link

Running 1.48.2 on my Pixel and it appears to still be broke. Changed the server, but not allowing me to use the preauthkey. Anybody found a fix?

@tailscale tailscale locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.