http2: revert more of upstream http2 change #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maisem
approved these changes
Jun 27, 2023
e4e1ae7 to
7d5ba0e
Compare
Even the part we previously kept was bad. Revert all of 82780d6 but keep 6826f5a (which depended on bits of 82780d6). So this is a mix. TestTransportRetryAfterRefusedStream fails with this change, but only because it was adjusted in 82780d6 to pass with 82780d6, and this test doesn't revert all the test changes. I just skip that test instead, because it doesn't really affect us. Updates tailscale/corp#12296 Updates golang/go#60818 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
7d5ba0e to
107da1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even the part we previously kept was bad. Revert all of 82780d6 but keep 6826f5a (which depended on bits of 82780d6). So this is a mix.
TestTransportRetryAfterRefusedStream fails with this change, but only because it was adjusted in 82780d6 to pass with 82780d6, and this test doesn't revert all the test changes. I just skip that test instead, because it doesn't really affect us.
Updates tailscale/corp#12296
Updates golang/go#60818