Skip to content

Commit

Permalink
bytes: remove builders check from compare test
Browse files Browse the repository at this point in the history
TestCompareBytes already took into account the -short
testing flag, however, only if not run on one of the Go builders.
This extra condition is no longer necessary as we have much
better longtest coverage than we did when the check was added.

Fixes golang#61071

Change-Id: I0fc716f4e7baa04019ee00608f223f27c931edcc
Reviewed-on: https://go-review.googlesource.com/c/go/+/507416
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
TryBot-Bypass: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
  • Loading branch information
johanbrandhorst authored and bradfitz committed Aug 2, 2023
1 parent a96a9ed commit 7bee426
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/bytes/compare_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ package bytes_test
import (
. "bytes"
"fmt"
"internal/testenv"
"testing"
)

Expand Down Expand Up @@ -73,7 +72,7 @@ func TestCompareBytes(t *testing.T) {
}
lengths = append(lengths, 256, 512, 1024, 1333, 4095, 4096, 4097)

if !testing.Short() || testenv.Builder() != "" {
if !testing.Short() {
lengths = append(lengths, 65535, 65536, 65537, 99999)
}

Expand Down

0 comments on commit 7bee426

Please sign in to comment.