Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod, actions: use mkctr to build multi-arch builds #59

Merged
merged 7 commits into from
Sep 6, 2024
Merged

go.mod, actions: use mkctr to build multi-arch builds #59

merged 7 commits into from
Sep 6, 2024

Conversation

Erisa
Copy link
Member

@Erisa Erisa commented Jul 20, 2024 •
edited
Loading

Closes #54

A test manifest was published to ghcr.io/tailscale-dev/tclip:multiarch

@Erisa Erisa mentioned this pull request Jul 20, 2024
Closed
@Erisa Erisa added enhancement New feature or request docker labels Jul 20, 2024
@Erisa Erisa marked this pull request as draft July 25, 2024 11:59
@Erisa Erisa force-pushed the erisa/docker-multiarch branch from 933a7ad to f795de2 Compare September 6, 2024 02:25
@Erisa
Copy link
Member Author

Erisa commented Sep 6, 2024

Updated ghcr.io/tailscale-dev/tclip:multiarch with new test version based on mkctr with command:

go run github.com/tailscale/mkctr --gopaths="./cmd/tclipd:/bin/tclipd" --tags="multiarch" --base="gcr.io/distroless/static" --repos=ghcr.io/tailscale-dev/tclip --push --ldflags="-w -s" -- /bin/tclipd

and tested working on amd64 and arm64.

@Erisa Erisa marked this pull request as ready for review September 6, 2024 02:33
@Erisa Erisa force-pushed the erisa/docker-multiarch branch from f795de2 to 5cce375 Compare September 6, 2024 02:51
@Erisa Erisa changed the title nix/docker: Add linux/arm64 Docker builds go.mod, actions: use mkctr to build multi-arch builds Sep 6, 2024
@Erisa Erisa requested a review from kradalby September 6, 2024 11:26
@Erisa Erisa merged commit 112ef7c into main Sep 6, 2024
1 check passed
@Erisa Erisa deleted the erisa/docker-multiarch branch September 6, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kradalby kradalby kradalby approved these changes

Assignees
No one assigned
Labels
docker enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Arm builds for Docker
2 participants
@Erisa @kradalby