fix(bridge-ui): renamed configuredCustomToken to configuredCustomTokens #15905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorbinianK
requested changes
Feb 21, 2024
There was a problem hiding this comment.
@arularmstrong I have reopened the PR again as you were right after all. It seems due to some rebase the fix has been reverted. But the package has since moved to bridge-ui now, please rebase your PR to the latest main and then we can merge it.
02f83f1 to
f6ff7bf
Compare
f6ff7bf to
5737418
Compare
|
@KorbinianK the PR is rebased with latest main |
KorbinianK
approved these changes
Feb 22, 2024
KorbinianK
requested changes
Feb 22, 2024
There was a problem hiding this comment.
@arularmstrong You need to remove the incorrectly named ones as well please.
KorbinianK
approved these changes
Feb 22, 2024
davidtaikocha
approved these changes
Feb 23, 2024
This was referenced Apr 24, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an inconsistency in the project's configuration file naming. The file in the config directory was originally named configuredCustomToken, while references elsewhere used configuredCustomTokens. To maintain consistency, I've renamed the file to configuredCustomTokens, aligning it with the Readme and other references.