build on pr + always use blobserver

taikoxyz · May 21, 2024 · 8f9189a · 8f9189a
1 parent c170497
commit 8f9189a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 19 deletions.
diff --git a/.github/workflows/taiko-client--docker.yml b/.github/workflows/taiko-client--docker.yml
@@ -7,6 +7,9 @@ on:
       - "taiko-client-v*"
     paths:
       - "packages/taiko-client/**"
+  pull_request:
+    paths:
+      - "packages/taiko-client/**"
 
 jobs:
   push-docker-image:

diff --git a/packages/taiko-client/pkg/rpc/blob_datasource.go b/packages/taiko-client/pkg/rpc/blob_datasource.go
@@ -61,29 +61,29 @@ func (ds *BlobDataSource) GetBlobs(
 		sidecars []*blob.Sidecar
 		err      error
 	)
-	if ds.client.L1Beacon == nil {
-		sidecars, err = nil, pkg.ErrBeaconNotFound
-	} else {
-		sidecars, err = ds.client.L1Beacon.GetBlobs(ctx, meta.Timestamp)
+	// if ds.client.L1Beacon == nil {
+	// 	sidecars, err = nil, pkg.ErrBeaconNotFound
+	// } else {
+	// 	sidecars, err = ds.client.L1Beacon.GetBlobs(ctx, meta.Timestamp)
+	// }
+	// if err != nil {
+	log.Info("Failed to get blobs from beacon, try to use blob server.", "error", err.Error())
+	if ds.blobServerEndpoint == nil {
+		log.Info("No blob server endpoint set")
+		return nil, err
 	}
+	blobs, err := ds.getBlobFromServer(ctx, meta.BlobHash)
 	if err != nil {
-		log.Info("Failed to get blobs from beacon, try to use blob server.", "error", err.Error())
-		if ds.blobServerEndpoint == nil {
-			log.Info("No blob server endpoint set")
-			return nil, err
-		}
-		blobs, err := ds.getBlobFromServer(ctx, meta.BlobHash)
-		if err != nil {
-			return nil, err
-		}
-		sidecars = make([]*blob.Sidecar, len(blobs.Data))
-		for index, value := range blobs.Data {
-			sidecars[index] = &blob.Sidecar{
-				KzgCommitment: value.KzgCommitment,
-				Blob:          value.Blob,
-			}
+		return nil, err
+	}
+	sidecars = make([]*blob.Sidecar, len(blobs.Data))
+	for index, value := range blobs.Data {
+		sidecars[index] = &blob.Sidecar{
+			KzgCommitment: value.KzgCommitment,
+			Blob:          value.Blob,
 		}
 	}
+	// }
 	return sidecars, nil
 }