Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage on latest nightly. #33

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix breakage on latest nightly. #33

merged 2 commits into from
Feb 20, 2020

Conversation

yotamofek
Copy link
Contributor

Broken here: rust-lang/rust#68524

@yotamofek yotamofek requested a review from taiki-e as a code owner February 14, 2020 14:15
@taiki-e
Copy link
Owner

taiki-e commented Feb 14, 2020

Thanks!

bors r+

@yotamofek
Copy link
Contributor Author

@taiki-e I don't think the bors check should be queued for this long,
quick glance at their docs says this could happen if the bot doesn't have the permissions necessary to force-push into the staging branch.
Also, thank YOU! Love this library.

@yotamofek
Copy link
Contributor Author

@taiki-e sorry to bother you, but I think it would be great if we could get this merged 🙏

@taiki-e
Copy link
Owner

taiki-e commented Feb 20, 2020

Oops, missed the notice, sorry.

I'll try again with bors and if it doesn't work, merge via the merge button.
bors r+

@taiki-e
Copy link
Owner

taiki-e commented Feb 20, 2020

Also, thank YOU! Love this library.

Thank you ❤️

@taiki-e
Copy link
Owner

taiki-e commented Feb 20, 2020

bors seems to be crashing again.
bors r-

@taiki-e taiki-e merged commit 36ce71a into taiki-e:master Feb 20, 2020
@taiki-e
Copy link
Owner

taiki-e commented Feb 20, 2020

Published in 0.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants