Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of -Z assume-incomplete-release #39

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Jan 3, 2022

Since 1.55, cargo pass CARGO_ENCODED_RUSTFLAGS instead of RUSTFLAGS to build-scripts: rust-lang/cargo#10111

Comment on lines +114 to +116
// https://github.com/rust-lang/cargo/issues/10111
if let Some(rustflags) = env::var_os("CARGO_ENCODED_RUSTFLAGS") {
for mut flag in rustflags.to_string_lossy().split('\x1f') {
Copy link
Owner Author

@taiki-e taiki-e Jan 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since only the nightly compiler requires this check, I don't implement a fallback to RUSTFLAGS for older versions.

@taiki-e
Copy link
Owner Author

taiki-e commented Jan 3, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build succeeded:

@bors bors bot merged commit 785ffe8 into main Jan 3, 2022
@bors bors bot deleted the cargo-encoded-rustflags branch January 3, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant