Testing new changes into multi-site-v1. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `libsndfile1-dev` as soft dependency.
…mproved CSV parsing
…gging Fix logging when all transmissions are removed.
Fixes issue mentioned in TrunkRecorder#691
Improve CSV parsing to allow quoted and escaped fields
Updated Broadcastify Uploader to make it more robust
plugman_audio_callback in p25_recorder_decode is sometimes call when d_call is an invalid pointer. This seems to be some form of race condition where d_call has been freed immediately before the audio callback is called, causing a segmentation fault in the simplestream plugin on line 63 (`call->get_system()`). By setting d_call to null when `p25_recorder_decode::stop()` is called, we can check for it being invalid before a plugin ever sees it, preventing a use-after-free segmentation fault.
…fault Set d_call to null to prevent potential use after free
Documenting maxDuration config param
The practice of declaring the Bind placeholders in the global namespace is deprecated. Setting BOOST_BIND_GLOBAL_PLACEHOLDERS will retain the old behavior.
The spdlog package sets SPDLOG_FMT_EXTERNAL internally, and then we re-declare it as SPDLOG_FMT_EXTERNAL=ON. This causes a warning. By simply setting SPDLOG_FMT_EXTERNAL, the declaration is the same and the warning stops
Boost.Math will require C++14 or greater in release 1.82, which is scheduled for July 2023. C++17 is the latest widely supported version so there seems to be no reason to not go to it now.
The current version of Eigen that is vendored in lib/lfsr is 5 to 6 years old (between commits 6bceebfab to 68e8f2b83). Additionally, increasing the C++ version results in warnings about std::unary_negate and std::binary_negate, which are deprecated in C++17 and removed in C++20. Eigen 3.3 contains a fix for this.
The CMake file to find the include dirs for gnuradio-osmosdr checks the wrong pkg module name, and has trailing paths appended.
Plus a Test Case on MQTT
need to remove it from the docs
Also made a slight change to the Cut-off filter to match OP25
This reverts commit f491855.
This reverts commit b8c8d4c.
In the previous attempt I had removed the check to see if Audio should be generated or not... which messed up things for Trunking Channels
…es-logging Cleanup dropped samples logging.
Multiple CMake fixes and version updates to resolve compiler warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.