Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ulong under the Number primitive. #40

Closed
4 tasks
tacosontitan opened this issue Apr 13, 2024 · 2 comments · Fixed by #31
Closed
4 tasks

Add support for ulong under the Number primitive. #40

tacosontitan opened this issue Apr 13, 2024 · 2 comments · Fixed by #31
Labels
enhancement New feature or request help wanted Extra attention is needed needs information The issue or pull request needs more information before it is ready
Milestone
Initial Release

Comments

@tacosontitan
Copy link
Owner

tacosontitan commented Apr 13, 2024 •
edited
Loading

The Number primitive needs support for ulong:

  • Implement IEquatable<ulong>.
  • Implement IComparable<ulong>.
  • Implement ISpanParsable<ulong>.
  • Unit test coverage for the implementations.

Note: The unit test coverage for the IEquatable implementation will be contributed by the repo owner.
@tacosontitan tacosontitan added enhancement New feature or request help wanted Extra attention is needed labels Apr 13, 2024
@tacosontitan tacosontitan added this to the Primitives milestone Apr 13, 2024
@tacosontitan tacosontitan linked a pull request Apr 13, 2024 that will close this issue
Added support for the Number primitive. #31
Merged
11 tasks
@tacosontitan tacosontitan mentioned this issue Apr 13, 2024
Closed
10 tasks
@tacosontitan tacosontitan added the needs information The issue or pull request needs more information before it is ready label Apr 13, 2024
@tacosontitan
Copy link
Owner Author

This issue needs information on which interfaces are implemented by the BCL types to ensure consistency with .NET runtime.

@tacosontitan
Copy link
Owner Author

Currently being discussed in #43 .

@tacosontitan tacosontitan moved this to Approved in 🔥Greatest Hits Sep 12, 2024
@tacosontitan tacosontitan moved this from Approved to Done in 🔥Greatest Hits Sep 12, 2024
@tacosontitan tacosontitan added this to the Initial Release milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed needs information The issue or pull request needs more information before it is ready
Projects
🔥Greatest Hits
Status: Done
Milestone
Initial Release
Development

Successfully merging a pull request may close this issue.

Added support for the Number primitive. tacosontitan/Hussy.Net
1 participant
@tacosontitan