Add tags to EKS-related subnets to support discovery for ELB #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the guidance in https://aws.amazon.com/premiumsupport/knowledge-center/eks-vpc-subnet-discovery/ around how to tag subnets in AWS, so that load balancers created for the purposes of EKS clusters can correctly choose subnets to be associated with.
In particular, the scheme we implement is:
kubernetes.io/role/elb
.kubernetes.io/role/internal-elb
. Otherwise (the subnets we create for EKS are public) we tag the subnets withkubernetes.io/role/elb
.The effect of these tags is that load balancers created by the cloud controller manager (to satisfy Service objects with
type: LoadBalancer
) or the ALB ingress controller are placed in the appropriate subnets. For us, at the time of this writing all load balancers are public, so we expect them to be created in the subnets tagged withkubernetes.io/role/elb
.