Refactor conditional creation of NAT gateway for EKS #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Terraform module
aws/nat_gateway
, all resources used have a conditionalcount
attribute, which is dependent on the variableuses_nat_gateway
: if the variable is false,count = 0
, and otherwise count is set to a value that creates resources.This PR refactors the conditional creation to be specified on the entire
module
declaration itself (which is available since Terraform 0.13), in order to simplify the code inside the module itself. The end result is the same, although any users of the module might need to dostate mv
operations because the internal Terraform address of the resources changes (things that used to bemodule.eks-vpc-nat-gateway.aws_eip.nat-gw-eip[0]
are nowmodule.eks-vpc-nat-gateway[0].aws_eip.nat-gw-eip
, for example).