Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log4j and jaxb #78

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Update log4j and jaxb #78

merged 1 commit into from
Jan 13, 2023

Conversation

jacalata
Copy link
Contributor

  • update log4j to log4j2
  • java11 requires jakarta since jaxb is no longer in the std lib
  • Also added some debug statements and separated out possible exceptions for easier debugging.
  • Updated the code to refer to config.properties instead of requiring the user to edit code before running.
  • Set a default API version so that the user doesn't have to find and download a schema before first run

@jacalata
Update log4j and jaxb
937905b 
- Also added some debug statements and separated out possible exceptions for easier debugging.
- Updated the code to refer to config.properties instead of requiring the user to edit code before running.
- Set a default API version so that first run is slightly simpler
@jacalata jacalata requested a review from dzucker-tab December 23, 2022 06:45
@jacalata jacalata mentioned this pull request Dec 23, 2022
Closed
@jacalata jacalata merged commit a9278d8 into development Jan 13, 2023
@jacalata jacalata deleted the jac/update-first-run branch January 13, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyoung-tableau anyoung-tableau anyoung-tableau approved these changes

@bhuvneshdev bhuvneshdev bhuvneshdev approved these changes

@dzucker-tab dzucker-tab Awaiting requested review from dzucker-tab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacalata @bhuvneshdev @anyoung-tableau