Experiment with worker redirection #606
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec59b61 to
afa8e96
Compare
davidegirardi
suggested changes
Jan 8, 2025
| panic(err) // it wouldn't have worked anyways | ||
| } | ||
| qs := parsedUrl.Query() | ||
| qs.Set(key, val) |
There was a problem hiding this comment.
Do we need to url-encode val or does Set() do it for us?
| @@ -1,9 +1,58 @@ | |||
| package _responses | |||
|
|
|||
| import ( | |||
| "crypto/hmac" | |||
| "crypto/sha256" | |||
There was a problem hiding this comment.
Is there a reason for not using sha512 for the HMACs?
There was a problem hiding this comment.
I read "use sha512" as "use sha256" for some reason - let's just use sha512.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready for usage, and makes a ton of assumptions. It's at best a proof of concept.