Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit m4 macros from source tree #32

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

andy-bower
Copy link
Contributor

Similar to build-aux/*, this directory can be sufficiently reconstructed with autoconf -i.

I had to install autoconf-archive on Debian to get the compiler detection working but that was a non-fatal failure anyway:

$ autoreconf -vis
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: running: autopoint
Creating directory build-aux
Copying file build-aux/config.rpath
Creating directory m4
Copying file m4/codeset.m4
Copying file m4/extern-inline.m4
Copying file m4/fcntl-o.m4
Copying file m4/gettext.m4
Copying file m4/glibc2.m4
Copying file m4/glibc21.m4
Copying file m4/iconv.m4
Copying file m4/intdiv0.m4
Copying file m4/intl.m4
Copying file m4/intldir.m4
Copying file m4/intlmacosx.m4
Copying file m4/intmax.m4
Copying file m4/inttypes-pri.m4
Copying file m4/inttypes_h.m4
Copying file m4/lcmessage.m4
Copying file m4/lib-ld.m4
Copying file m4/lib-link.m4
Copying file m4/lib-prefix.m4
Copying file m4/lock.m4
Copying file m4/longlong.m4
Copying file m4/nls.m4
Copying file m4/po.m4
Copying file m4/printf-posix.m4
Copying file m4/progtest.m4
Copying file m4/size_max.m4
Copying file m4/stdint_h.m4
Copying file m4/threadlib.m4
Copying file m4/uintmax_t.m4
Copying file m4/visibility.m4
Copying file m4/wchar_t.m4
Copying file m4/wint_t.m4
Copying file m4/xsize.m4
autoreconf: running: aclocal -I m4
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: /usr/bin/autoconf
autoreconf: running: /usr/bin/autoheader
autoreconf: running: automake --add-missing --no-force
configure.ac:16: installing 'build-aux/compile'
configure.ac:16: installing 'build-aux/config.guess'
configure.ac:16: installing 'build-aux/config.sub'
configure.ac:16: installing 'build-aux/install-sh'
configure.ac:19: installing 'build-aux/missing'
src/Makefile.am: installing 'build-aux/depcomp'
autoreconf: Leaving directory '.'

@t-brown t-brown self-assigned this Oct 21, 2024
@t-brown
Copy link
Owner

t-brown commented Oct 22, 2024

Yeah, I was thinking the same thing. Also I don't know if I really care about compiler identification. Your output isn't showing any ax_* macros getting copied in (from the autoconf-archive). Interesting.

It also seems I am not actually call the C attribute check.

OK, happy to delete m4, could you also remove line 27 and line 103 from configure.ac?

@andy-bower
Copy link
Contributor Author

Your output isn't showing any ax_* macros getting copied in (from the autoconf-archive). Interesting.

I noticed that, too, but it did make the configure warnings go away and stop the compiler identification in the summary from being blank!

I wonder if the content of the macros got moved into one of the other definition files.

But I'm with you on this... we don't actually need to know!

@t-brown
Copy link
Owner

t-brown commented Oct 23, 2024

LGTM. Thanks.

@t-brown t-brown merged commit d45d262 into t-brown:master Oct 23, 2024
1 check passed
@andy-bower andy-bower deleted the no-m4 branch November 9, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants