forked from dart-lang/pub-dev
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Admin action for moderating a Publisher + tests. (dart-lang#7590)
- Loading branch information
Showing
9 changed files
with
296 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'package:pub_dev/publisher/backend.dart'; | ||
| import 'package:pub_dev/publisher/models.dart'; | ||
| import 'package:pub_dev/shared/datastore.dart'; | ||
|
|
||
| import 'actions.dart'; | ||
|
|
||
| final moderatePublisher = AdminAction( | ||
| name: 'moderate-publisher', | ||
| summary: | ||
| 'Set the moderated flag on a publisher (making it invisible and unable to change).', | ||
| description: ''' | ||
| Set the moderated flag on a publisher (updating the flag and the timestamp). The | ||
| moderated package page page says it is moderated, packages owned by publisher | ||
| can't be updated, administrators must not be able to update publisher options. | ||
| ''', | ||
| options: { | ||
| 'publisher': 'The publisherId to be moderated', | ||
| 'state': | ||
| 'Set moderated state true / false. Returns current state if omitted.', | ||
| }, | ||
| invoke: (options) async { | ||
| final publisherId = options['publisher']; | ||
| InvalidInputException.check( | ||
| publisherId != null && publisherId.isNotEmpty, | ||
| 'publisherId must be given', | ||
| ); | ||
|
|
||
| final publisher = await publisherBackend.getPublisher(publisherId!); | ||
| InvalidInputException.check( | ||
| publisher != null, 'Unable to locate publisher.'); | ||
|
|
||
| final state = options['state']; | ||
| bool? valueToSet; | ||
| switch (state) { | ||
| case 'true': | ||
| valueToSet = true; | ||
| break; | ||
| case 'false': | ||
| valueToSet = false; | ||
| break; | ||
| } | ||
|
|
||
| Publisher? publisher2; | ||
| if (valueToSet != null) { | ||
| publisher2 = await withRetryTransaction(dbService, (tx) async { | ||
| final p = await tx.lookupValue<Publisher>(publisher!.key); | ||
| p.updateIsModerated(isModerated: valueToSet!); | ||
| tx.insert(p); | ||
| return p; | ||
| }); | ||
| await purgePublisherCache(publisherId: publisherId); | ||
| } | ||
|
|
||
| return { | ||
| 'publisherId': publisher!.publisherId, | ||
| 'before': { | ||
| 'isModerated': publisher.isModerated, | ||
| 'moderatedAt': publisher.moderatedAt?.toIso8601String(), | ||
| }, | ||
| if (publisher2 != null) | ||
| 'after': { | ||
| 'isModerated': publisher2.isModerated, | ||
| 'moderatedAt': publisher2.moderatedAt?.toIso8601String(), | ||
| }, | ||
| }; | ||
| }, | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'package:_pub_shared/data/admin_api.dart'; | ||
| import 'package:_pub_shared/data/publisher_api.dart'; | ||
| import 'package:clock/clock.dart'; | ||
| import 'package:pub_dev/fake/backend/fake_auth_provider.dart'; | ||
| import 'package:pub_dev/publisher/backend.dart'; | ||
| import 'package:pub_dev/search/backend.dart'; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| import '../frontend/handlers/_utils.dart'; | ||
| import '../package/backend_test_utils.dart'; | ||
| import '../shared/handlers_test_utils.dart'; | ||
| import '../shared/test_models.dart'; | ||
| import '../shared/test_services.dart'; | ||
|
|
||
| void main() { | ||
| group('Moderate Publisher', () { | ||
| Future<AdminInvokeActionResponse> _moderate( | ||
| String publisher, { | ||
| bool? state, | ||
| }) async { | ||
| final api = createPubApiClient(authToken: siteAdminToken); | ||
| return await api.adminInvokeAction( | ||
| 'moderate-publisher', | ||
| AdminInvokeActionArguments(arguments: { | ||
| 'publisher': publisher, | ||
| if (state != null) 'state': state.toString(), | ||
| }), | ||
| ); | ||
| } | ||
|
|
||
| testWithProfile('update state and clearing it', fn: () async { | ||
| final r1 = await _moderate('example.com'); | ||
| expect(r1.output, { | ||
| 'publisherId': 'example.com', | ||
| 'before': {'isModerated': false, 'moderatedAt': null}, | ||
| }); | ||
|
|
||
| final r2 = await _moderate('example.com', state: true); | ||
| expect(r2.output, { | ||
| 'publisherId': 'example.com', | ||
| 'before': {'isModerated': false, 'moderatedAt': null}, | ||
| 'after': {'isModerated': true, 'moderatedAt': isNotEmpty}, | ||
| }); | ||
| final p2 = await publisherBackend.getPublisher('example.com'); | ||
| expect(p2!.isModerated, isTrue); | ||
|
|
||
| final r3 = await _moderate('example.com', state: false); | ||
| expect(r3.output, { | ||
| 'publisherId': 'example.com', | ||
| 'before': {'isModerated': true, 'moderatedAt': isNotEmpty}, | ||
| 'after': {'isModerated': false, 'moderatedAt': isNull}, | ||
| }); | ||
| final p3 = await publisherBackend.getPublisher('example.com'); | ||
| expect(p3!.isModerated, isFalse); | ||
| }); | ||
|
|
||
| testWithProfile('not able to publish', fn: () async { | ||
| await _moderate('example.com', state: true); | ||
| final pubspecContent = generatePubspecYaml('neon', '2.0.0'); | ||
| final bytes = await packageArchiveBytes(pubspecContent: pubspecContent); | ||
|
|
||
| await expectApiException( | ||
| createPubApiClient(authToken: adminClientToken) | ||
| .uploadPackageBytes(bytes), | ||
| code: 'InsufficientPermissions', | ||
| status: 403, | ||
| message: 'insufficient permissions to upload new versions', | ||
| ); | ||
|
|
||
| await _moderate('example.com', state: false); | ||
| final message = await createPubApiClient(authToken: adminClientToken) | ||
| .uploadPackageBytes(bytes); | ||
| expect(message.success.message, contains('Successfully uploaded')); | ||
| }); | ||
|
|
||
| testWithProfile('not able to update publisher options', fn: () async { | ||
| await _moderate('example.com', state: true); | ||
| final client = await createFakeAuthPubApiClient(email: 'admin@pub.dev'); | ||
| await expectApiException( | ||
| client.updatePublisher( | ||
| 'example.com', UpdatePublisherRequest(description: 'update')), | ||
| status: 404, | ||
| code: 'NotFound', | ||
| message: 'Publisher "example.com" has been moderated.', | ||
| ); | ||
|
|
||
| await _moderate('example.com', state: false); | ||
| final rs = await client.updatePublisher( | ||
| 'example.com', UpdatePublisherRequest(description: 'update')); | ||
| expect(rs.description, 'update'); | ||
| }); | ||
|
|
||
| testWithProfile('publisher pages show it is moderated', fn: () async { | ||
| final htmlUrls = [ | ||
| '/publishers/example.com/packages', | ||
| '/publishers/example.com/unlisted-packages', | ||
| ]; | ||
| Future<void> expectAvailable() async { | ||
| for (final url in htmlUrls) { | ||
| await expectHtmlResponse( | ||
| await issueGet(url), | ||
| absent: ['moderated'], | ||
| present: ['/publishers/example.com/'], | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| await expectAvailable(); | ||
|
|
||
| await _moderate('example.com', state: true); | ||
| for (final url in htmlUrls) { | ||
| await expectHtmlResponse( | ||
| await issueGet(url), | ||
| status: 404, | ||
| absent: ['/publishers/example.com/'], | ||
| present: ['moderated'], | ||
| ); | ||
| } | ||
|
|
||
| await _moderate('example.com', state: false); | ||
| await expectAvailable(); | ||
| }); | ||
|
|
||
| testWithProfile('not included in search', fn: () async { | ||
| await searchBackend.doCreateAndUpdateSnapshot( | ||
| FakeGlobalLockClaim(clock.now().add(Duration(seconds: 3))), | ||
| concurrency: 2, | ||
| sleepDuration: Duration(milliseconds: 300), | ||
| ); | ||
| final docs = await searchBackend.fetchSnapshotDocuments(); | ||
| expect(docs!.where((d) => d.package == 'neon'), isNotEmpty); | ||
|
|
||
| await _moderate('example.com', state: true); | ||
|
|
||
| final minimumIndex = | ||
| await searchBackend.loadMinimumPackageIndex().toList(); | ||
| expect(minimumIndex.where((e) => e.package == 'neon'), isEmpty); | ||
|
|
||
| await searchBackend.doCreateAndUpdateSnapshot( | ||
| FakeGlobalLockClaim(clock.now().add(Duration(seconds: 3))), | ||
| concurrency: 2, | ||
| sleepDuration: Duration(milliseconds: 300), | ||
| ); | ||
| final docs2 = await searchBackend.fetchSnapshotDocuments(); | ||
| expect(docs2!.where((d) => d.package == 'neon'), isEmpty); | ||
|
|
||
| await _moderate('example.com', state: false); | ||
|
|
||
| final minimumIndex2 = | ||
| await searchBackend.loadMinimumPackageIndex().toList(); | ||
| expect(minimumIndex2.where((e) => e.package == 'neon'), isNotEmpty); | ||
|
|
||
| await searchBackend.doCreateAndUpdateSnapshot( | ||
| FakeGlobalLockClaim(clock.now().add(Duration(seconds: 3))), | ||
| concurrency: 2, | ||
| sleepDuration: Duration(milliseconds: 300), | ||
| ); | ||
| final docs3 = await searchBackend.fetchSnapshotDocuments(); | ||
| expect(docs3!.where((d) => d.package == 'neon'), isNotEmpty); | ||
| }); | ||
| }); | ||
| } |