propagate SOURCE_DATE_EPOCH when calling systemd-repart #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behrmann
approved these changes
Aug 24, 2023
Sounds like a good idea. I'll do a follow up PR after understanding how run works. Or do you prefer that to happen in this PR? |
DaanDeMeyer
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, setting
Environment=SOURCE_DATE_EPOCH=0in the mkosi config, mkosi will propagate the variable to systemd-repart.systemd-repart calls mksquashfs and other mkfs tools.
Some mkfs tools already respect SOURCE_DATE_EPOCH, resulting in predictable timestamps in squashfs partitions (and maybe others).