-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show color hex value as swatch title #2324
Conversation
@braaar is attempting to deploy a commit to the Theme UI Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c1e4f7f:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
You updated the package.json, and to pass the installation with frozen lockfile on CI, you'll need to run pnpm install
and then commit the pnpm-lock.yaml
. I tried to do this for you, but I can't push to your develop :P
I'll get on it |
I'm not getting a new lockfile when running |
I invited you as a collaborator on my fork, @hasparus 🤷 |
Thanks! For the future — There should be a checkbox somewhere in the PR called "Allow edits from maintainers", so you don't need to add everybody as collaborators. Edit: That might have been a problem on my side. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
get color value using
getColor
from@theme-ui/color
instead ofget
fromtheme-ui
.fixes #2112
See the issue for more details
Version
Published prerelease version:
v0.15.0-develop.29
Changelog
🎉 This release contains work from new contributors! 🎉
Thanks for all your work!
❤️ Luke Watts (@thisislawatts)
❤️ Valto Savi (@pointlessrapunzel)
Release Notes
Pull out MDX to be opt-in (#2288)
Breaking:
theme-ui
no longer includes@theme-ui/mdx
— MDX is now opt-in.If your project is not using MDX or importing
Themed
, you shouldn't need tochange anything.
MDXProvider
is no longer included in Theme UIThemeProvider
, and has beenremoved in favour of an
useThemedStylesWithMdx
hook.Migration: Use
useThemedStylesWithMdx
together withMDXProvider
anduseMDXComponents
from@mdx-js/react
.Themed
components dict and other exports from@theme-ui/mdx
are no longer reexported fromtheme-ui
.Migration: Import it from
@theme-ui/mdx
instead.Remove @theme-ui/editor (#2292)
@theme-ui/editor
was removed. Use CSS GUI instead./customize
page in Theme UI docs has been removed. Use Components.ai Theme Builder or an alternative instead.Drop support for React 16 + 17 (#2215)
Theme UI 0.15.0 drops support for React 16 and React 17. Your use case may still work, but we don't guarantee it.
🚀 Enhancement
🐛 Bug Fix
👨💻 Minor changes
🏠 Internal
Authors: 7