Add manage_init_script parameter

Fixes voxpupuli#541.

manifests/agent.pp

@@ -177,6 +177,9 @@
 # [*loadmodule*]
 #   Module to load at agent startup.
 #
+# [*manage_init_script*]
+#  If the init script should be managed by this module. Attention: This might cause problems with some config options of this module (e.g agent_configfile_path)
+#
 # === Example
 #
 #  Basic installation:
@@ -263,6 +266,7 @@
   Hash[String, Array] $selinux_rules      = $zabbix::params::selinux_rules,
   String $additional_service_params       = $zabbix::params::additional_service_params,
   String $service_type                    = $zabbix::params::service_type,
+  Boolean $manage_init_script             = $zabbix::params::manage_init_script,
 ) inherits zabbix::params {
 
   # the following two codeblocks are a bit blargh. The correct default value for
@@ -340,14 +344,16 @@
   }
 
   # Ensure that the correct config file is used.
-  zabbix::startup {$servicename:
-    pidfile                   => $pidfile,
-    agent_configfile_path     => $agent_configfile_path,
-    zabbix_user               => $zabbix_user,
-    additional_service_params => $real_additional_service_params,
-    service_type              => $real_service_type,
-    service_name              => 'zabbix-agent',
-    require                   => Package[$zabbix_package_agent],
+  if $manage_init_script {
+    zabbix::startup {$servicename:
+      pidfile                   => $pidfile,
+      agent_configfile_path     => $agent_configfile_path,
+      zabbix_user               => $zabbix_user,
+      additional_service_params => $real_additional_service_params,
+      service_type              => $real_service_type,
+      service_name              => 'zabbix-agent',
+      require                   => Package[$zabbix_package_agent],
+    }
   }
 
   if $agent_configfile_path != '/etc/zabbix/zabbix_agentd.conf' {

manifests/params.pp

@@ -104,6 +104,7 @@
   $zabbix_web_ip                            = '127.0.0.1'
   $manage_database                          = true
   $manage_service                           = true
+  $manage_init_script                       = true
   $default_vhost                            = false
   $manage_firewall                          = false
   $manage_apt                               = true

manifests/server.pp

@@ -258,6 +258,9 @@
 # [*sslkeylocation_dir*]
 #   Location of SSL private key files for client authentication.
 #
+# [*manage_init_script*]
+#  If the init script should be managed by this module. Attention: This might cause problems with some config options of this module (e.g server_configfile_path)
+#
 # === Example
 #
 #   When running everything on a single node, please check
@@ -378,6 +381,7 @@
   Boolean $manage_selinux           = $zabbix::params::manage_selinux,
   String $additional_service_params = $zabbix::params::additional_service_params,
   Optional[String[1]] $zabbix_user  = $zabbix::params::server_zabbix_user,
+  Boolean $manage_init_script       = $zabbix::params::manage_init_script,
 ) inherits zabbix::params {
 
   # the following codeblock is a bit blargh. The correct default value for
@@ -458,15 +462,17 @@
   }
 
   # Ensure that the correct config file is used.
-  zabbix::startup {'zabbix-server':
-    pidfile                   => $pidfile,
-    database_type             => $database_type,
-    server_configfile_path    => $server_configfile_path,
-    zabbix_user               => $zabbix_user,
-    additional_service_params => $real_additional_service_params,
-    manage_database           => $manage_database,
-    service_name              => 'zabbix-server',
-    require                   => Package["zabbix-server-${db}"],
+  if $manage_init_script {
+    zabbix::startup {'zabbix-server':
+      pidfile                   => $pidfile,
+      database_type             => $database_type,
+      server_configfile_path    => $server_configfile_path,
+      zabbix_user               => $zabbix_user,
+      additional_service_params => $real_additional_service_params,
+      manage_database           => $manage_database,
+      service_name              => 'zabbix-server',
+      require                   => Package["zabbix-server-${db}"],
+    }
   }
 
   if $server_configfile_path != '/etc/zabbix/zabbix_server.conf' {

spec/classes/agent_spec.rb

@@ -144,6 +144,16 @@
         end
       end
 
+      context 'when declaring manage_init_script is false' do
+        let :params do
+          {
+            manage_init_script: false
+          }
+        end
+
+        it { is_expected.not_to contain_zabbix__startup('zabbix-agent') }
+      end
+
       context 'when declaring zabbix_alias' do
         let :params do
           {

spec/classes/server_spec.rb

@@ -126,6 +126,27 @@
         it { is_expected.not_to contain_firewall('151 zabbix-server') }
       end
 
+      context 'it creates a startup script' do
+        case facts[:osfamily]
+        when 'Archlinux', 'Fedora'
+          it { is_expected.to contain_file('/etc/init.d/zabbix-server').with_ensure('absent') }
+          it { is_expected.to contain_file('/etc/systemd/system/zabbix-server.service').with_ensure('file') }
+        else
+          it { is_expected.to contain_file('/etc/init.d/zabbix-server').with_ensure('file') }
+          it { is_expected.not_to contain_file('/etc/systemd/system/zabbix-server.service') }
+        end
+      end
+
+      context 'when declaring manage_init_script is false' do
+        let :params do
+          {
+            manage_init_script: false
+          }
+        end
+
+        it { is_expected.not_to contain_zabbix__startup('zabbix-server') }
+      end
+
       # If manage_service is true (default), it should create a service
       # and ensure that it is running.
       context 'when declaring manage_service is true' do