Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sysdig] Update default registry, correct host analyzer schedule, fix readme #150

Merged
merged 2 commits into from
May 18, 2021

Conversation

nestorsalceda
Copy link
Contributor

Duplicated form #149

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@nestorsalceda nestorsalceda changed the title Nkraemer sysdig fix/node analyzer [sysdig] Update default registry, correct host analyzer schedule, fix readme May 18, 2021
@nestorsalceda nestorsalceda merged commit 531c32e into master May 18, 2021
@nestorsalceda nestorsalceda deleted the nkraemer-sysdig-fix/node-analyzer branch May 18, 2021 19:17
@nestorsalceda
Copy link
Contributor Author

Finally merged @nkraemer-sysdig

I don't know why the linter is trolling, but on any case, thank you for the PR!

@nkraemer-sysdig
Copy link
Contributor

Regarding the linter I think this is the issue:

Since I'm running the CI on a fork the Expand templates for CI step is supplying " " as the secrets since I don't have access to secrets.KUBELAB_AGENT_KEY:

From the Action logs:

  find -iname "*.yaml.template" | xargs -L1 -- bash -c 'envsubst < $0 > ${0%.template}'
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.7.10/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.7.10/x64/lib
    CT_CONFIG_DIR: /opt/hostedtoolcache/ct/v3.3.0/x86_64/etc
    VIRTUAL_ENV: /opt/hostedtoolcache/ct/v3.3.0/x86_64/venv
    SECURE_API_TOKEN: 
    SECURE_AGENT_TOKEN: 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants