Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admission-controller] Upgrade to 3.1.0 #143

Merged
merged 1 commit into from
May 11, 2021
Merged

[admission-controller] Upgrade to 3.1.0 #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/admission-controller/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: admission-controller
description: Sysdig Admission Controller using Sysdig Secure inline image scanner
type: application
version: 0.3.0
appVersion: 3.0.0
version: 0.4.0
appVersion: 3.1.0
home: https://sysdiglabs.github.io/admission-controller/
icon: https://478h5m1yrfsa3bbe262u7muv-wpengine.netdna-ssl.com/wp-content/uploads/2019/02/Shovel_600px.png
maintainers:
Expand Down
1 change: 1 addition & 0 deletions charts/admission-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Controller chart and their default values:
| `webhook.nodeSelector` | Configure nodeSelector for scheduling for webhook | `{}` |
| `webhook.tolerations` | Tolerations for scheduling for webhook | `[]` |
| `webhook.affinity` | Configure affinity rules for webhook | `{}` |
| `webhook.denyOnError` | Deny request when an error happened evaluating request | `false` |
| `scanner.enabled` | Deploy the Inline Scanner Service | `true` |
| `scanner.name` | Service name for Scanner deployment | `scanner` |
| `scanner.replicaCount` | Amount of replicas for scanner | `1` |
Expand Down
4 changes: 4 additions & 0 deletions charts/admission-controller/templates/webhook/admissionregistration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ webhooks:
admissionReviewVersions: ["v1", "v1beta1"]
sideEffects: None
timeoutSeconds: 15
{{- if .Values.webhook.denyOnError }}
failurePolicy: Fail
{{- else }}
failurePolicy: Ignore
{{- end }}
{{- if .Values.features.k8sAuditDetections }}
- name: audit.secure.sysdig.com
matchPolicy: Equivalent
Expand Down
1 change: 1 addition & 0 deletions charts/admission-controller/templates/webhook/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ data:
PUBLISH_ON_EVENT_FEED: "{{ .Values.features.publishOnSecureEventFeed }}"
VERIFY_SSL: "{{ .Values.verifySSL }}"
K8S_AUDIT_DETECTIONS: "{{ .Values.features.k8sAuditDetections }}"
DENY_ON_ERROR: "{{ .Values.webhook.denyOnError }}"
2 changes: 2 additions & 0 deletions charts/admission-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ webhook:

affinity: {}

denyOnError: false

# inline scanner configuration
scanner:
enabled: true
Expand Down