Module syntax #1457
Merged
Module syntax #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadleynet
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request targets module syntax cleanliness.
Some of these changes are not functional, for example, removing unused extra fields from the JSON.
Some of them are errors that were luckily avoided during runtime, due to code preferring one parameter to another, or relying on defaults or not.
Many of these syntax issues are artifacts of the module builder. For example, copying & pasting modules rather than "downloading" them results in extra
namefields. Inserting a state into a model can shift a transition, leaving a state with two transitions (but only rendering the last one), and so forth.