This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Part of #6905, support for go 1.13.1, fixed openshift_funcs to handle new version string #6906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d openshift_funcs to handle new version string from crc oc client
zregvart
suggested changes
Oct 17, 2019
| @@ -51,4 +51,6 @@ replace ( | |||
| sigs.k8s.io/controller-tools => sigs.k8s.io/controller-tools v0.1.11-0.20190411181648-9d55346c2bde | |||
| ) | |||
|
|
|||
| replace git.apache.org/thrift.git => github.com/apache/thrift v0.12.0 | |||
| replace git.apache.org/thrift.git => github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999 | |||
There was a problem hiding this comment.
Not sure about this, if we used v0.12.0 and now we're switching to apache/thrift@2566ecd5d999, we would miss 68 commits.
|
I had the same issue with go 1.13 and switched back to 1.1.2. What's the benefit of using 1.13 over 1.12? |
|
Similar changes merged from other PRs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.