Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint(ci): add nightly wheel uploads per SPEC 4 #27186

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

oscarbenjamin
Copy link
Collaborator

https://scientific-python.org/specs/spec-0004/
scientific-python/upload-nightly-action#111

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
https://scientific-python.org/specs/spec-0004/
https://github.com/scientific-python/upload-nightly-action/issues/111

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@sympy-bot
Copy link

🟠

Hi, I am the SymPy bot. I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it.

This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75.

The following commits add new files:

  • 353e259:
    • .github/workflows/nightly-wheels.yml

If these files were added/deleted on purpose, you can ignore this message.

@oscarbenjamin
Copy link
Collaborator Author

There's no way to test this without merging so I'm just going to merge it.

@oscarbenjamin oscarbenjamin merged commit 4eabaff into sympy:master Oct 23, 2024
18 checks passed
@asmeurer
Copy link
Member

Don't we need git versions first? #27116 Otherwise all the nightly versions are going to just be "1.14.dev".

@oscarbenjamin
Copy link
Collaborator Author

You don't need multiple nightly versions. It is just supposed to be "today's version". You can see the wheels uploaded for numpy here:
https://anaconda.org/scientific-python-nightly-wheels/numpy/files?page=1

It would be useful to be able to distinguish which commit someone use retrospectively but that is mostly not needed because they will mainly be used in CI and the point is just that it always gets the most recent upload anyway.

@asmeurer
Copy link
Member

I didn't realize NumPy would have the same problem. I agree it won't matter for ephemeral things like CI builds, but it would make it harder to use this for something more persistent, because pip would not know that the package should be updated, or even that it's a different file.

At any rate, the commit hash thing is definitely useful for nightly builds because you can see right from the pip install log exactly what commit of SymPy is being installed. Without that, you just have to guess from the timestamps or other things.

@oscarbenjamin
Copy link
Collaborator Author

To be clear I agree that it would be good to have the commit hash in the version and in the filename. I just don't think it is a necessary precondition for having nightly wheels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants