-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint(ci): add nightly wheel uploads per SPEC 4 #27186
Conversation
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
🟠Hi, I am the SymPy bot. I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files:
If these files were added/deleted on purpose, you can ignore this message. |
There's no way to test this without merging so I'm just going to merge it. |
Don't we need git versions first? #27116 Otherwise all the nightly versions are going to just be "1.14.dev". |
You don't need multiple nightly versions. It is just supposed to be "today's version". You can see the wheels uploaded for numpy here: It would be useful to be able to distinguish which commit someone use retrospectively but that is mostly not needed because they will mainly be used in CI and the point is just that it always gets the most recent upload anyway. |
I didn't realize NumPy would have the same problem. I agree it won't matter for ephemeral things like CI builds, but it would make it harder to use this for something more persistent, because pip would not know that the package should be updated, or even that it's a different file. At any rate, the commit hash thing is definitely useful for nightly builds because you can see right from the pip install log exactly what commit of SymPy is being installed. Without that, you just have to guess from the timestamps or other things. |
To be clear I agree that it would be good to have the commit hash in the version and in the filename. I just don't think it is a necessary precondition for having nightly wheels. |
https://scientific-python.org/specs/spec-0004/
scientific-python/upload-nightly-action#111
References to other Issues or PRs
Brief description of what is fixed or changed
Other comments
Release Notes
NO ENTRY