-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize package.json files, to prepare publication on NPM #2595
base: 2.x
Are you sure you want to change the base?
Conversation
src/Autocomplete/assets/package.json
Outdated
"symfony-ux" | ||
], | ||
"homepage": "https://ux.symfony.com/autocomplete", | ||
"repository": "https://github.com/symfony/ux/tree/2.x/src/Autocomplete", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: should this be the monorepo or the split one ?
( https://github.com/symfony/ux-autocomplete [...] ) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use splited repositories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mind using monorepo here, as it is a go-to place for proposing contributions etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem is, JsDeliver, Packagist, etc;... do not work well with monorepo... so it depends on "how" this package.json attribute is used (I have no idea so I will trust you guys on this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough then 👍
edcce14
to
f2da909
Compare
This is a first iteration for #2575: rework our
package.json
files in order to make them more "friendly" and work on npm.Next steps:
version
frompackage.json
files, commit, push, and publish to npm)