Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize package.json files, to prepare publication on NPM #2595

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Feb 23, 2025

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

This is a first iteration for #2575: rework our package.json files in order to make them more "friendly" and work on npm.

Next steps:

  1. Add some verifications, to ensure PHP and JS versions of a same package are identical (and so 100% compatible)
  2. See how we can deploy JS packages when creating a new UX releases. I'm thinking about a full automated process using the CI with a workflow listening on tag creation, which will be responsible to upgrade the version from package.json files, commit, push, and publish to npm)
  3. Check if we need to manually create the packages on npm before trying to publishing them

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 23, 2025
@Kocal Kocal requested review from kbond, smnandre and WebMamba February 23, 2025 09:09
"symfony-ux"
],
"homepage": "https://ux.symfony.com/autocomplete",
"repository": "https://github.com/symfony/ux/tree/2.x/src/Autocomplete",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: should this be the monorepo or the split one ?

( https://github.com/symfony/ux-autocomplete [...] ) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use splited repositories

Copy link
Contributor

@skmedix skmedix Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mind using monorepo here, as it is a go-to place for proposing contributions etc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem is, JsDeliver, Packagist, etc;... do not work well with monorepo... so it depends on "how" this package.json attribute is used (I have no idea so I will trust you guys on this)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough then 👍

@Kocal Kocal force-pushed the prepare-js-pkgs-for-npm branch from edcce14 to f2da909 Compare February 24, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants