Fixed case where service definition is actually an alias #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!$container->hasDefinition('acme_mailer.transport_chain')) { | ||
| try { | ||
| $definition = $container->findDefinition('acme_mailer.transport_chain'); | ||
| } catch (\InvalidArgumentException $e) { |
There was a problem hiding this comment.
I would rather just call has() here.
There was a problem hiding this comment.
has() / get() methods should be used instead yeah. But anyhow, I think this shouldn't be left like this
There was a problem hiding this comment.
Can you update the code accordingly?
|
5000 PR 🎉 |
| return; | ||
| } | ||
|
|
||
| $definition = $container->getDefinition( | ||
| $definition = $container->get( |
There was a problem hiding this comment.
You shouldn't use get() in a compiler pass (the definition may be modified by other passes). Use findDefinition() instead.
Added exception catch Changed methods used Revert
|
👍 |
|
🎉 |
|
Wow, this is really subtle! Very nice catch @xavismeh! Ok, we're half way to 10,000. Let's get to work! ;) |
weaverryan
added a commit
that referenced
this pull request
Mar 2, 2015
…avier Coureau) This PR was merged into the 2.3 branch. Discussion ---------- Fixed case where service definition is actually an alias If `acme_mailer.transport_chain` service would be an alias, the `hasDefinition` method would return `false` and would fake the expected result. Same for the further call on `getDefinition` method. Commits ------- c9caef6 Fixed case where definition service is an alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
acme_mailer.transport_chainservice would be an alias, thehasDefinitionmethod would returnfalseand would fake the expected result.Same for the further call on
getDefinitionmethod.